[Avatar] rollback, use ligter border color #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| size, | ||
| src, | ||
| style, | ||
| ...other, | ||
| } = this.props; | ||
|
|
||
| const boxShadow = (style && style.boxShadow) ? style.boxShadow : '0 0 1px 0 rgba(0, 0, 0, 0.2) inset'; | ||
| const borderRadius = (style && style.borderRadius) ? style.borderRadius : '50%'; | ||
|
|
||
| let styles = { | ||
| root: { | ||
| height: size, | ||
| width: size, | ||
| userSelect: 'none', | ||
| backgroundColor: backgroundColor, |
There was a problem hiding this comment.
@oliviertassinari backgroundColor should not be set for image avatars as well.
With backgroundColor:
Without backgroundColor:
|
@hai-cea good eyes! |
hai-cea
added a commit
that referenced
this pull request
Jul 29, 2015
[Avatar] rollback, use ligter border color
|
Thanks @oliviertassinari |
oliviertassinari
referenced
this pull request
Aug 24, 2015
I can't find the border on the spec of material design.
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
After mui#1236, a few imports were remaining, remove those imports. Also use type `Omit` from typescript utility types. This will ensure zero direct references to `@material-ui/core`.
zannager
added
the
component: avatar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow discusion in #1204.
Better rendering performance.
Add a new
avatar.borderColortheme property. If set to null, no border is displayed.