-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avatar] remove border on images and use boxShadow #1204
Conversation
@oliviertassinari When I was implementing lists, I notice the image Avatars have borders. Please see: |
Ok but I feel like the border is less than 1px on this example. On the project I'm working on, I have two issues. |
@hai-cea What do you think? |
@oliviertassinari I think the |
@hai-cea Updated. Left : this PR, right: master |
I can't find the border on the spec of material design.
Thanks @oliviertassinari - looks great. 👍 |
[Avatar] remove border on images and use boxShadow
"remove border on images and use boxShadow" <-- border fast, boxShadow slow. you guys are trading asthetics for speed right now. Just saying. Maybe it's not a big deal but in the future. BoxShadows are terribly slow to render |
I agree it's slower. |
Looks good to me, and if anyone wants more they can always override themselves and take the perf penalty |
@hai-cea Ok, why not. let's kill it. |
I can't find the border on the spec of material design.