-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP V2.0 #127
base: master
Are you sure you want to change the base?
WIP V2.0 #127
Conversation
Are you sure you really need react for this? A resume is pretty much static, and thus React might bring a bit much overhead. Especially since the most common use case is hosting this on a static file host (such as github/gitlab pages). Can I help? |
Not on the client side just to generate the resume on the server side, similar to how Gatsby lets you generate static files while you develop them using React.
Yes! I do need to scope out my plan a bit, I'll do it soon 🤞 |
Alright, I can help since I have React experience, but the pug solution here seems quite fine. What do you think would change if using React? Are you considering using some specific react component libraries (other than react-icons)? |
I assume a lot more people would be able to contribute and I have a feeling the custom pug solution has a higher barrier of entry
React icons and snapshot testing |
I don't think pug is a bad tech for this, due to the static nature of the page. I would maybe refactor a bit and organize the thing better. That has a much bigger effect on the maintainability than the language. |
Schema 1.0:
meta