Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP V2.0 #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP V2.0 #127

wants to merge 3 commits into from

Conversation

mudassir0909
Copy link
Owner

@mudassir0909 mudassir0909 commented Jan 20, 2021


Schema 1.0:

  • work experience location
  • project keywords
  • project roles
  • project type
  • meta
  • publication type

@njelich
Copy link

njelich commented May 31, 2021

Are you sure you really need react for this? A resume is pretty much static, and thus React might bring a bit much overhead. Especially since the most common use case is hosting this on a static file host (such as github/gitlab pages).

Can I help?

@mudassir0909
Copy link
Owner Author

mudassir0909 commented Jun 1, 2021

Are you sure you really need react for this?

Not on the client side just to generate the resume on the server side, similar to how Gatsby lets you generate static files while you develop them using React.

Can I help?

Yes! I do need to scope out my plan a bit, I'll do it soon 🤞

@njelich
Copy link

njelich commented Jun 3, 2021

Alright, I can help since I have React experience, but the pug solution here seems quite fine.

What do you think would change if using React? Are you considering using some specific react component libraries (other than react-icons)?

@mudassir0909
Copy link
Owner Author

mudassir0909 commented Jun 7, 2021

What do you think would change if using React?

I assume a lot more people would be able to contribute and I have a feeling the custom pug solution has a higher barrier of entry

Are you considering using some specific react component libraries (other than react-icons)?

React icons and snapshot testing

@njelich
Copy link

njelich commented Jun 8, 2021

I don't think pug is a bad tech for this, due to the static nature of the page. I would maybe refactor a bit and organize the thing better. That has a much bigger effect on the maintainability than the language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants