Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showing social icon urls when printed #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EvanLovely
Copy link

This PR will show social link URL when printed or exported to a PDF.

class="link-" + profile.label + " icon-" + profile.label)
title= resume.basics.name + " on " + profile.network)
i.fs-lg.social-link-icon(class="link-" + profile.label + " icon-" + profile.label)
span.social-link-label #{profile.url}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can reuse bootstrap's visible-print-inline-block class here?

@wahidshafique
Copy link

I'm curious, why is this PR just sitting here? @mudassir0909 is this project still alive?

@mudassir0909
Copy link
Owner

I'm curious, why is this PR just sitting here?

If I remember I probably didn't merge this because the comments weren't addressed.

@mudassir0909 is this project still alive?

This project is using a lot of legacy tech and I am not very keen on updating existing code, I did start a 2.0 rewrite to use React + CSS flexbox but have always been getting sidetracked by life. Can't call it dead but I don't get enough time these days.

@wahidshafique
Copy link

I'm curious, why is this PR just sitting here?

If I remember I probably didn't merge this because the comments weren't addressed.

@mudassir0909 is this project still alive?

This project is using a lot of legacy tech and I am not very keen on updating existing code, I did start a 2.0 rewrite to use React + CSS flexbox but have always been getting sidetracked by life. Can't call it dead but I don't get enough time these days.

Ah ok, I understand, life has a way of doing that :) Good luck on your endeavors, and if you ever put the rewrite up, I'll be sure to download it and perhaps contribute as well, your template has been the prettiest I've seen so far 👍

@mudassir0909 mudassir0909 mentioned this pull request Jan 20, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants