dependencies: Temporarily pin old version of jupyter-client. #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosperate
force-pushed
the
jupyter-client
branch
from
5869066
to
d527d6f
Compare
|
LGTM; we obviously need to dive further into the issue, but this works for now |
…ity.
- There was an issue in jupyter-client v6.1.13 that broke qtconsole
- Next jupyter-client release will be v6.2 and won't support Python 3.5
- We are currently using qtconsole v4, which does supports Python 3.5
- qtconsole v5 drops Python 3.5
- We should stay with jupyter-client<6.2 & qtconsole v4 for Mu v1.1 release
- This would be mostly to support Debian (and specifically Raspbian)
Stretch and Ubuntu 16.04 users, both still supported, but not for long
- After v1.1 is release we should finally drop Python 3.5
- I hope, but don't know yet, that jupyter-client v6.2 will fix the issues
with qtconsole without qtconsole having to create a new release
- If it does, then we wouldn't need to pin jupyter-client, as pip should
detect the `python_requires` and install the last compatible version
- If it doesn't, there might be a qtconsole release for compatibility
with the latest jupyter-client, but neither will be Python 3.6+
So, itprobably safer to lock jupyter-client < v6.2 & qtconsole to v4. The
jupyter-client min version comes from qtconsole v4 (checked their setup.py)
More info: #1444 (comment)
carlosperate
force-pushed
the
jupyter-client
branch
from
d527d6f
to
48928d2
Compare
|
I've rebased to fix the conflict in setup.py from the latest merge, and refined the comment. I'm not totally sure we'll need this PR, I guess that'll depend on the next jupyter-client and qtconsole release. |
|
I had to resolve a conflict introduced by the recent Adafruit update... but that was simple to do. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a workaround for #1444.