-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with the latest jupyter-client version 6.1.13 #1444
Comments
Okay, so So the CI should be passing again now, and the Python3 REPL in new Mu builds should be working again 🎉 However:
Updated #1445 with this in mind. |
…ity. - There was an issue in jupyter-client v6.1.13 that broke qtconsole - Next jupyter-client release will be v6.2 and won't support Python 3.5 - We are currently using qtconsole v4, which does supports Python 3.5 - qtconsole v5 drops Python 3.5 - We should stay with jupyter-client<6.2 & qtconsole v4 for Mu v1.1 release - This would be mostly to support Debian (and specifically Raspbian) Stretch and Ubuntu 16.04 users, both still supported, but not for long - After v1.1 is release we should finally drop Python 3.5 - I hope, but don't know yet, that jupyter-client v6.2 will fix the issues with qtconsole without qtconsole having to create a new release - If it does, then we wouldn't need to pin jupyter-client, as pip should detect the `python_requires` and install the last compatible version - If it doesn't, there might be a qtconsole release for compatibility with the latest jupyter-client, but neither will be Python 3.6+ So, itprobably safer to lock jupyter-client < v6.2 & qtconsole to v4. The jupyter-client min version comes from qtconsole v4 (checked their setup.py) More info: #1444 (comment)
…ity. - There was an issue in jupyter-client v6.1.13 that broke qtconsole - Next jupyter-client release will be v6.2 and won't support Python 3.5 - We are currently using qtconsole v4, which does supports Python 3.5 - qtconsole v5 drops Python 3.5 - We should stay with jupyter-client<6.2 & qtconsole v4 for Mu v1.1 release - This would be mostly to support Debian (and specifically Raspbian) Stretch and Ubuntu 16.04 users, both still supported, but not for long - After v1.1 is release we should finally drop Python 3.5 - I hope, but don't know yet, that jupyter-client v6.2 will fix the issues with qtconsole without qtconsole having to create a new release - If it does, then we wouldn't need to pin jupyter-client, as pip should detect the `python_requires` and install the last compatible version - If it doesn't, there might be a qtconsole release for compatibility with the latest jupyter-client, but neither will be Python 3.6+ So, itprobably safer to lock jupyter-client < v6.2 & qtconsole to v4. The jupyter-client min version comes from qtconsole v4 (checked their setup.py) More info: #1444 (comment)
We are protected against these changes with #1443, which has been merged. |
Released this mornig:
These issues are reverted when downgrading to 6.1.12, but need to investigate further.
This is causing issues running the tests in Python 3.5:
And also trying to run with Python 3.6:
The text was updated successfully, but these errors were encountered: