New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: types #476

Merged

mtth merged 4 commits into mtth:master from joscha:joscha/type-definedtype

Sep 28, 2024

Contributor

joscha commented Sep 23, 2024 •

edited

Loading

Fixes the type issue described in #461 and adds a fixture for it.
Also introduces a CI check to test the type definitions:

Screenshot 2024-09-23 at 12 37 31 PM

closes #461


          fix: types

d72d021

joscha commented

View reviewed changes

package.json Show resolved Hide resolved

joscha commented

View reviewed changes

types/test/461.ts Outdated Show resolved Hide resolved

joscha commented

View reviewed changes

types/index.d.ts Show resolved Hide resolved

joscha commented

View reviewed changes

.npmignore Outdated Show resolved Hide resolved


          style: newlines at EOF

0dfe8f4

joscha commented

View reviewed changes

.npmignore Outdated Show resolved Hide resolved

joscha mentioned this pull request

Using seprately declared enum in union in record. #461

Closed

joscha added 2 commits

September 24, 2024 17:33


          Update package.json

fa198ce


          Delete .npmignore

8d0d137

joscha requested a review from mtth

September 24, 2024 07:35

Contributor Author

joscha commented Sep 25, 2024

@mtth any chance to get this one in?

Owner

mtth commented Sep 28, 2024

@joscha - please avoid bumping threads unless it's urgent or been more than a week, it adds noise to my notifications. I already do what I can to check in regularly.

mtth merged commit cf91be6 into mtth:master

3 checks passed

Contributor Author

joscha commented Sep 28, 2024

@joscha - please avoid bumping threads unless it's urgent or been more than a week, it adds noise to my notifications. I already do what I can to check in regularly.

Apologies, I did because part of this PR was overlapping with #479

joscha deleted the joscha/type-definedtype branch

September 28, 2024 20:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet