Fix forSchema argument type (#476)

Also introduce a CI check to test the type definitions.

.github/workflows/ci.yml

@@ -32,3 +32,5 @@ jobs:
         run: npm i
       - name: Test
         run: npm t
+      - name: Check types
+        run: npm run check-types

package.json

@@ -30,7 +30,7 @@
   "files": [
     "etc/browser",
     "lib",
-    "types"
+    "types/index.d.ts"
   ],
   "main": "./lib",
   "types": "./types",
@@ -43,18 +43,21 @@
     "node": ">=6.0.0"
   },
   "scripts": {
+    "check-types": "tsc --strict --noEmit types/test/*.ts",
     "clean": "rm -rf coverage node_modules",
     "cover": "nyc mocha -- --ui tdd",
     "lint": "eslint etc/ lib/ test/ \"etc/scripts/**\"",
     "perf": "node --expose-gc ./etc/scripts/perf etc/schemas/*",
     "test": "mocha --ui tdd --reporter dot"
   },
   "devDependencies": {
+    "@types/node": "^22.5.5",
     "benchmark": "~2.1.4",
     "eslint": "^8.30.0",
     "mocha": "^10.2.0",
     "nyc": "~15.0.0",
-    "tmp": "^0.1.0"
+    "tmp": "^0.1.0",
+    "typescript": "^5.6.2"
   },
   "author": {
     "name": "Matthieu Monsch",

types/index.d.ts

@@ -7,12 +7,11 @@
 // `any` is appropriate.
 
 import * as stream from 'stream';
-import { EventEmitter } from 'events';
 
 //"virtual" namespace (no JS, just types) for Avro Schema
 declare namespace schema {
-  export type AvroSchema = DefinedType | DefinedType[] | Type | Type[];
-  type DefinedType = PrimitiveType | ComplexType | LogicalType | string;
+  export type AvroSchema = DefinedType | DefinedType[];
+  type DefinedType = PrimitiveType | ComplexType | LogicalType | Type | string;
   type PrimitiveType = 'null' | 'boolean' | 'int' | 'long' | 'float' | 'double' | 'bytes' | 'string';
   type ComplexType = NamedType | RecordType | EnumType | MapType | ArrayType | FixedType;
   type LogicalType = ComplexType & LogicalTypeExtension;

types/test/461.ts

@@ -0,0 +1,15 @@
+import * as Avro from '../index'
+
+const e = Avro.Type.forSchema({
+    name: "enum",
+    type: "enum",
+    symbols: ["foo", "bar", "baz"],
+});
+
+const record = Avro.Type.forSchema({
+    name: "record",
+    type: "record",
+    fields: [
+        { name: "enum", type: ["null", e], default: null },
+    ],
+});