-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add -c log.showsignature=false
to all git log
commands
#75
fix: add -c log.showsignature=false
to all git log
commands
#75
Conversation
Thanks for this! One issue is that |
…t version is >= 2.10.0 Signed-off-by: Patrick Decat <[email protected]>
946a037
to
9c49a84
Compare
Hi @mtkennerly, done! Note: |
"git log --simplify-by-decoration --topo-order" | ||
' --decorate=full {} "--format=%H%d"'.format(tag_branch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's certainly room to improve this and avoid duplication, but I've seen this pattern used below, so I figured I'd stick to it.
Maybe extracting git log commands into a function would help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A way more intrusive change would be to use something like https://github.com/jelmer/dulwich or https://github.com/gitpython-developers/GitPython to avoid having to deal with such details altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can definitely try to reduce some of the duplication, but I think it's okay for now.
I'd like to keep Dunamai's dependencies pretty minimal; otherwise, yeah, Dulwich or GitPython could be nice.
This PR is a follow up to #51 and resolves issues where
log.showSignature = true
is set in git config, e.g.:A work-around is to ignore the git configuration during installation:
Signed-off-by: Patrick Decat [email protected]