Enforce '--no-show-signature' on git-log timestamp retrieval #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I've experienced a problem building the copier project from source using the
poetry build
command.copier
uses poetry-dynamic-versioning.The
poetry build
command fails with the following error:The
git
command that is at the origin of the problem is:The gpg signature headers get in the way of the timestamp retrieval logic.
My git configuration
This signature is displayed because I do have
in my
~/.gitconfig
file.Can I reproduce with other projects ?
I was able to reproduce the problem with other projects relying on
poetry-dynamic-versioning
.Proposed solution
I know that the root cause of the problem is the
showSignature = true
setting in my~/.gitconfig
file.But if we enforce the
--no-show-signature
git-log
flag, we ensures that no Signature message could get in the way of thegit-log timestamp
parsing logic.