Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: meta data in navbar now has release date and reformatted last… #83

Merged
merged 4 commits into from
Mar 17, 2019
Merged

update: meta data in navbar now has release date and reformatted last… #83

merged 4 commits into from
Mar 17, 2019

Conversation

staghouse
Copy link
Member

@staghouse staghouse commented Mar 6, 2019 •
edited
Loading

Changelog

  • Added date to meta data in navbar
  • Added meta data to mobile sidebar to show meta data when not enough room
  • Reformatted last updated time at bottom of pages to match the standard time used in meta data
  • Changed talk to us button text to take up less room
  • Removed unnecessary alt text for logo

Close #80 Close #79

@ZeldaZach
Copy link
Member

When I click on a specific changelog entry, it highlights the one above it (but scrolls to the correct one)
screenshot 2019-03-06 13 26 14

Changed talk to us button text to take up less room

Not sure I like it just as "Talk"

@staghouse
Copy link
Member Author

staghouse commented Mar 6, 2019 •
edited
Loading

The above issue is unrelated to this ticket - its a universal flaw with Vuepress + smooth scrolling. Will open a ticket. See #84

@ZeldaZach
Copy link
Member

Sounds good, but i still have an issue with "Talk"

tooomm
tooomm reviewed Mar 7, 2019
View reviewed changes
docs/.vuepress/config.js Outdated Show resolved Hide resolved
@ZeldaZach ZeldaZach merged commit 64c8137 into master Mar 17, 2019
@ZeldaZach ZeldaZach deleted the issue/80 branch March 18, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tooomm tooomm tooomm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staghouse @ZeldaZach @tooomm