Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor links on changelog do not always scroll to accurate position #84

Closed
staghouse opened this issue Mar 6, 2019 · 6 comments
Closed
Labels
Bug Something isn't working Deferred Ticket will be addressed under different conditions

Comments

@staghouse
Copy link
Member

  1. The anchors for headline release do not have enough spacing to accommodate the fixed navigation which can cause, in part, this issue.
  2. Investigate he simple smooth-scroll capability. Removing its current implementation may resolve this.
@staghouse
Copy link
Member Author

staghouse commented Mar 18, 2019

There is currently no possible solution for keeping smooth scroll + keeping anchor tags all presented in the changelog.

Read through the warnings of this to see why.

We can, however, disable smooth scrolling for the time being to keep anchor link integrity.

@ancestral @ZeldaZach, please see above note. Shall we bench smooth scroll for now?

@ZeldaZach
Copy link
Member

I like smooth scrolling. Also, that URL is dead.

@staghouse
Copy link
Member Author

Link updated. TL;DR, we might have to handle the changelog differently or reformat the heading styling. Would require some experimentation at this point is all.

@staghouse staghouse added the Bug Something isn't working label Mar 21, 2019
@staghouse staghouse added the Upstream Issue caused by upstream depenencies label Mar 29, 2019
@staghouse
Copy link
Member Author

This is a thing with limited support: https://css-tricks.com/fixed-headers-on-page-links-and-overlapping-content-oh-my/

@staghouse staghouse removed their assignment May 2, 2019
@staghouse
Copy link
Member Author

After further investigation this is a problem also assisted by the way we automatically "documentize" a markdown changelog:

When anchoring to a headline the page expects the previous anchor to be out of view. Because the changelog markdown is not directly markup, there is no way to target the section/headline in CSS and add more spacing intelligently and with regard to any and all future markdown formatting.

Further investigation is warranted.

@staghouse
Copy link
Member Author

Final thoughts and then im closing this ticket because its stale and the conditions are no longer as accurate:

This is unfixable as long as we have a fixed navigation. There is, to my knowledge, in Vuepress and all browsers a way to win this battle.

@staghouse staghouse added Deferred Ticket will be addressed under different conditions and removed Upstream Issue caused by upstream depenencies labels Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Deferred Ticket will be addressed under different conditions
Projects
None yet
Development

No branches or pull requests

2 participants