Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS - baseline - Convert Bootstrap prep deployment file to bicep (acr-stamp) #286

Merged
merged 10 commits into from
Feb 15, 2022

Conversation

magrande
Copy link
Contributor

No description provided.

@magrande magrande requested a review from ckittel February 15, 2022 16:51
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Couple suggestions below.

acr-stamp.bicep Outdated Show resolved Hide resolved
acr-stamp.bicep Show resolved Hide resolved
acr-stamp.bicep Outdated Show resolved Hide resolved
acr-stamp.bicep Outdated Show resolved Hide resolved
acr-stamp.bicep Outdated Show resolved Hide resolved
acr-stamp.bicep Outdated Show resolved Hide resolved
acr-stamp.bicep Outdated Show resolved Hide resolved
acr-stamp.bicep Outdated Show resolved Hide resolved
@ckittel
Copy link
Member

ckittel commented Feb 15, 2022

Thank you @magrande and @teilmeier (ref: #285) for this next step in the migration. Once all the JSON templates have been migrated in-place, we'll be coming back to building out the module-per-resource direction that @teilmeier is proposing in #285. We might even go down a private bicep registry part for the last step (since we have an ACR instance separate from the last step). All TBD and is on the backlog for consideration.

Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magrande and @teilmeier

@ckittel ckittel merged commit 524f19d into main Feb 15, 2022
@ckittel ckittel deleted the bicep-acr branch February 15, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants