Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bicep Templates for ACR, KeyVault, AppGW, and AKS #285

Closed
wants to merge 5 commits into from

Conversation

teilmeier
Copy link
Contributor

Here are Bicep Templates based on the acr-stamp and cluster-stamp ARM templates. Currently the flux part is commented out and the version is a few commits behind the main branch. But I think it's a good starting point.

@ckittel
Copy link
Member

ckittel commented Feb 11, 2022

Awesome timing. We have an engineer currently working on this right now. @magrande, can you please coordinate your work with this contribution?

@ckittel
Copy link
Member

ckittel commented Feb 15, 2022

The work to convert this repo into bicep has two phases. The first is an in-place migration from JSON to bicep. The second will be to refactor into modules as is the norm for bicep and as is proposed here in this PR. We will be keeping a separation though between the ACR deployment and the cluster (unlike proposed here) to continue to teach the importance of bootstrapping resources being available to the cluster prior to the cluster being deployed.

@teilmeier, we'd love to have you join us on this phased migration, aligning with the work we've got in our backlog for this. We have resources already allocated to the migration and a project plan (and style guide, etc). As seen by the work done by @magrande in #286. If you would like to help us accelerate the migration, please reach out to me so we can coordinate the work and not run into any duplicated efforts (like what just happened) and we can also make sure no rework is necessary (and risk is minimized) by following the phased migration approach. Please reach out to me on Teams to discuss next steps. Welcome aboard!

[I'm going to convert this PR to DRAFT/WIP to indicate it's just a collaboration PR at this point.]

@ckittel ckittel changed the title Bicep Templates for ACR, KeyVault, AppGW, and AKS [WIP] Bicep Templates for ACR, KeyVault, AppGW, and AKS Feb 15, 2022
@ckittel ckittel marked this pull request as draft February 15, 2022 17:58
@teilmeier teilmeier deleted the branch mspnp:main March 2, 2022 12:02
@teilmeier teilmeier closed this Mar 2, 2022
@teilmeier teilmeier deleted the main branch March 2, 2022 12:02
@teilmeier teilmeier restored the main branch March 2, 2022 12:04
@teilmeier teilmeier deleted the main branch March 2, 2022 12:18
@teilmeier
Copy link
Contributor Author

Restructured my fork repo's branches. I'll create a new PR containing the Bicep-related changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants