Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of boost in chrono.hpp #1006

Closed
wants to merge 1 commit into from
Closed

get rid of boost in chrono.hpp #1006

wants to merge 1 commit into from

Conversation

brandonros
Copy link

fixes #1005

brandonros
brandonros commented Feb 20, 2022
View reviewed changes
include/msgpack/v1/adaptor/cpp11/chrono.hpp
#include <boost/numeric/conversion/cast.hpp>
//#include <boost/numeric/conversion/cast.hpp>

template<typename Dst, typename Src>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from https://stackoverflow.com/questions/49658182/does-c-have-an-equivalent-boostnumeric-castdesttypesourcetype

@redboltz
Copy link
Contributor

Thanks you for sending the PR but CI reports errors . After they whould be solved, I will reveiw the PR.

This was referenced Mar 4, 2022
Merged
Merged
@uyha
Copy link

uyha commented Jul 6, 2023

superseded by #1076

@brandonros brandonros closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonros @redboltz @uyha