Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimall supported build without boost. #1001

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

redboltz
Copy link
Contributor

@redboltz redboltz commented Feb 7, 2022

To remove boost dependency, -DMSGPACK_USE_BOOST=OFF for cmake.
By default, -DMSGPACK_USE_BOOST is ON.
NOTE: In order to build tests -DMSGPACK_USE_BOOST=ON is required.

For C++ compiler, the option -DMSGPACK_NO_BOOST is required to remove
boost.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #1001 (9e14be5) into cpp_master (59f2da6) will not change coverage.
The diff coverage is n/a.

❗ Current head 9e14be5 differs from pull request most recent head 066d509. Consider uploading reports for the commit 066d509 to get more accurate results

@@             Coverage Diff             @@
##           cpp_master    #1001   +/-   ##
===========================================
  Coverage       85.56%   85.56%           
===========================================
  Files              79       79           
  Lines            5009     5009           
===========================================
  Hits             4286     4286           
  Misses            723      723           

@redboltz redboltz force-pushed the minimal_support_for_no_boost branch 2 times, most recently from 9d579c1 to 9e14be5 Compare February 7, 2022 13:11
To remove boost dependency, `-DMSGPACK_USE_BOOST=OFF` for cmake.
By default, `-DMSGPACK_USE_BOOST` is `ON`.
NOTE: In order to build tests `-DMSGPACK_USE_BOOST=ON` is required.

For C++ compiler, the option `-DMSGPACK_NO_BOOST` is required to remove
boost.
@redboltz redboltz force-pushed the minimal_support_for_no_boost branch from 9e14be5 to 066d509 Compare February 7, 2022 13:33
@redboltz redboltz merged commit cd885d2 into msgpack:cpp_master Feb 12, 2022
@redboltz redboltz deleted the minimal_support_for_no_boost branch February 12, 2022 07:39
@holmesconan
Copy link

It seem the no boost here is not done? include/msgpack/v1/adaptor/cpp11/chrono.hpp still contains boost headers.

@redboltz
Copy link
Contributor Author

redboltz commented Mar 4, 2022

See #1006 . It seems that no additional commit is pushed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants