-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing "close" for spdlog? #82
Comments
Yes, I noticed that sometimes the log was truncated, so I added a “flush” call in my internal repository, but having a better look at the docs, a “shutdown” call is also needed (look here: https://spdlog.docsforge.com/v1.x/0.faq/#memory-leak-detected-when-using-inside-a-shared-library) |
mridoni
added a commit
that referenced
this issue
Jul 13, 2022
- Added support for "smart" cursor initialization (#88) - Added support for EXECUTE prepared-statement INTO #(87) - Fixed a logging problem (#84) - Fixed "wrong generated COBOL in 1.0.16" (#83) - Fixed "missing "close" for spdlog?" (#82) - Added support for using prepared statements in cursors (#81) - Variable length fields indicators are now 32-bit long by default (#80) - Added support for using variable length fields with prepared statements (#79) - Added upport for using group fields in INSERT and SELECT..INTO statements (#6) - Added support for more connection string formats (including ocesql compatibility) (#16) - Added Support for DISCONNECT ALL (#89) - Performed some refactoring to improve code size - Fixed a few memory leaks
fixed (per release notes - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure if you've added a close function on unloading the module, if not then there possibly is one.
If you do and you think that's done correctly then there's either a possible bug in spdlog (which one of us should forward upstream), which is possibly already solved in the newest version or a "by design decission - the OS cleans that at process exit in any case".
I'd like to know what the issue is, and will use a suppression rule for spdlog in the meantime.
Currently valgrind's memcheck
--leak-check=full --show-leak-kinds=all
says:The text was updated successfully, but these errors were encountered: