Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have USE_VARLEN_32 be the default as long as there's a fixed varlen #80

Closed
GitMensch opened this issue Jul 5, 2022 · 4 comments
Closed

Comments

@GitMensch
Copy link
Contributor

So I do wonder: Shouldn't USE_VARLEN_32 be the default as long as there's a fixed varlen only?

Yes, that's probably for the better, I'll add this to the next batch of fixes.

Originally posted by @mridoni in #54 (comment)

... just found out: that default wasn't changed in GixSQL 1.0.16 yet, please do so for upcoming release.

@mridoni
Copy link
Owner

mridoni commented Jul 5, 2022

You are right, I forgot, thanks for pointing it out.

@mridoni
Copy link
Owner

mridoni commented Jul 10, 2022

Changed in the internal repository to use 32 bit indicators as the default. 16-bit indicators are available when defining USE_VARLEN_16 (USE_VARLEN_32 is not in use anymore).

@mridoni
Copy link
Owner

mridoni commented Jul 11, 2022

This change (luckily) exposed a few bugs that have been caught during the regression tests and are currently being fixed.

mridoni added a commit that referenced this issue Jul 13, 2022
- Added support for "smart" cursor initialization (#88)
- Added support for EXECUTE prepared-statement INTO #(87)
- Fixed a logging problem (#84)
- Fixed "wrong generated COBOL in 1.0.16" (#83)
- Fixed "missing "close" for spdlog?" (#82)
- Added support for using prepared statements in cursors (#81)
- Variable length fields indicators are now 32-bit long by default (#80)
- Added support for using variable length fields with prepared statements (#79)
- Added upport for using group fields in INSERT and SELECT..INTO statements (#6)
- Added support for more connection string formats (including ocesql compatibility) (#16)
- Added Support for DISCONNECT ALL (#89)
- Performed some refactoring to improve code size
- Fixed a few memory leaks
@GitMensch
Copy link
Contributor Author

fixed (per release notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants