Unused reference to .buffer #6875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`attribute.buffer` does seem to exist anymore. The only `.buffer` property I could find was in `Audio`. This seems to be a leftover from 4c7239e, when `.buffer` was renamed `.__webglBuffer`. After stepping through with a debugger in `onGeometryDispose`, I couldn't find any hidden state attached to the `BufferAttribute`. `.__webglBuffer` is attached to the `WebGLProperties`, not the `BufferAttribute`. With that, the last reference to `gl.deleteBuffer` is disappearing from the library. Is that expected?
Yeah, the disposing for geometry is still on the works. We can remove this by now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attribute.bufferdoes seem to exist anymore. The only.bufferproperty I could find was inAudio.This seems to be a leftover from 4c7239e, when
.bufferwas renamed.__webglBuffer.After stepping through with a debugger in
onGeometryDispose, I couldn't find any hidden state attached to theBufferAttribute..__webglBufferis attached to theWebGLProperties, not theBufferAttribute.With that, the last reference to
gl.deleteBufferis disappearing from the library. Is that expected?