Fix an issue where buffers don't get deleted #6862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this seems a bit entangled. I'll think about the issue. |
gero3
changed the title
|
I can update the system to make sure that attributes are only accessed from webglGeometries which is where they belong. |
|
I just noticed that this tackles the same problem as #6875, but is more aggressive about deleting buffers. |
|
Ended up merging this one too. Thanks @gero3! |
|
Hmm... I think attributes could benefit of some clean up. The code for them is now spread around |
|
Geat! I was concerned that deleting the attribute buffers in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix for #6729
Make sure buffers get deleted