Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Removes <!-- includes --> replacement code when emits app #28627

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Editor: Removes <!-- includes --> replacement code when emits app #28627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions editor/js/Sidebar.Project.App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,6 @@ function SidebarProjectApp( editor ) {

content = content.replace( '<!-- title -->', title );

const includes = [];

content = content.replace( '<!-- includes -->', includes.join( '\n\t\t' ) );
Copy link
Collaborator

@Mugen87 Mugen87 Jun 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was part of the initial VR support, see f8e0e54. It is indeed not required anymore.

If we ever want to include addons in published apps, we should use a different approach in any event. I have outlined one possible approach in #28187 (comment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented #28636


let editButton = '';

if ( config.getKey( 'project/editable' ) ) {
Expand Down