Editor: Removes <!-- includes --> replacement code when emits app
#28627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Jun 11, 2024
| @@ -115,10 +115,6 @@ function SidebarProjectApp( editor ) { | |||
|
|
|||
| content = content.replace( '<!-- title -->', title ); | |||
|
|
|||
| const includes = []; | |||
|
|
|||
| content = content.replace( '<!-- includes -->', includes.join( '\n\t\t' ) ); | |||
There was a problem hiding this comment.
This was part of the initial VR support, see f8e0e54. It is indeed not required anymore.
If we ever want to include addons in published apps, we should use a different approach in any event. I have outlined one possible approach in #28187 (comment).
Mugen87
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This token
<!-- includes -->is not present at editor/js/libs/app/index.html, so removes the replacement code.