Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture: Clean up #26814

Closed
wants to merge 1 commit into from
Closed

Texture: Clean up #26814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/textures/Texture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ class Texture extends EventDispatcher {
this.internalFormat = null;
this.type = type;

this.offset = new Vector2( 0, 0 );
Copy link
Collaborator

@Mugen87 Mugen87 Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was originally done to be more explicit and I don't think this needs refactoring.

Sorry but I'm really against such PRs since even if the review effort is minor it still costs time. And these PRs do not add a real value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right.

This place is more intuitive if it's explicit.

I just revised the PR #26775, by the way to see this, feel can delete...

Maybe we need to do something more worthwhile

To be honest, I'd like to do some feature development, but I don't know how to start...

Anyway, thank you for your patience and your review time.

this.offset = new Vector2();
this.repeat = new Vector2( 1, 1 );
this.center = new Vector2( 0, 0 );
this.center = new Vector2();
this.rotation = 0;

this.matrixAutoUpdate = true;
Expand Down