Texture: Clean up #26814
Closed
Texture: Clean up #26814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Sep 20, 2023
| @@ -53,9 +53,9 @@ class Texture extends EventDispatcher { | |||
| this.internalFormat = null; | |||
| this.type = type; | |||
|
|
|||
| this.offset = new Vector2( 0, 0 ); | |||
There was a problem hiding this comment.
This was originally done to be more explicit and I don't think this needs refactoring.
Sorry but I'm really against such PRs since even if the review effort is minor it still costs time. And these PRs do not add a real value.
There was a problem hiding this comment.
Yes, you're right.
This place is more intuitive if it's explicit.
I just revised the PR #26775, by the way to see this, feel can delete...
Maybe we need to do something more worthwhile
To be honest, I'd like to do some feature development, but I don't know how to start...
Anyway, thank you for your patience and your review time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
Remove unnecessary code for
Texture.