Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object3D: Updated static class properties to ALL_CAPS #25188

Merged
merged 3 commits into from
Jan 2, 2023

Conversation

WestLangley
Copy link
Collaborator

As proposed in #25015 (comment).

@WestLangley WestLangley added this to the r149 milestone Dec 23, 2022
src/core/Object3D.js Outdated Show resolved Hide resolved
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 2, 2023

LGTM!

@WestLangley WestLangley merged commit b1c7e14 into mrdoob:dev Jan 2, 2023
@WestLangley
Copy link
Collaborator Author

Merged for now. Migration docs have already been updated.

I'll fix if there is an issue.

build required, pls.

@WestLangley WestLangley deleted the dev-object3d_static branch January 2, 2023 19:39
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 3, 2023

build required, pls.

8fd3b2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants