Zooming to cursor position in OrbitControls #24979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Nov 18, 2022
| @@ -25,6 +25,9 @@ class OrbitControls extends EventDispatcher { | |||
|
|
|||
| super(); | |||
|
|
|||
| if ( domElement === undefined ) console.warn( 'THREE.OrbitControls: The second parameter "domElement" is now mandatory.' ); | |||
| if ( domElement === document ) console.error( 'THREE.OrbitControls: "document" should not be used as the target "domElement". Please use "renderer.domElement" instead.' ); | |||
There was a problem hiding this comment.
Something is not right with this PR. You are adding unrelated changes. Consider to rebase your branch. Besides, please do not modify examples/js/controls/OrbitControls.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #17145 and #18202
Proposing solution for zooming to mouse cursor/mobile touch pinch position in OrbitControls.
Working both for PerspectiveCamera and OrthographicCamera.
Working for both OrbitControls and MapControls.
Working both for mouse and touch events.
Working with and withount damping enabled.
No problem with division by 0.
To enable zooming to cursor: controls.enableZoomToCursor = true, default is false.