Zoom over position. #18202
Closed
Zoom over position. #18202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zooming over point of interest (under cursor), not over center of canvas. Available to switch on that option, by setting this.zoomOverPosition = true; Disabled by default.
|
Does your PR aim for the same goal as #17145? |
Looks similar, but my solution for OrthographicCamera |
|
The PR of @WestLangley actually supports both orthographic and perspective cameras. Since it's important for maintenance to focus on one solution, it would be good to know how your implementation differs from #17145. |
|
Closing in favor of #17145. Thanks for your effort though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zooming over point of interest (under cursor), not over center of canvas.
Available to switch on that option, by setting this.zoomOverPosition = true;
Disabled by default.