-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrthographicSSRPass (screen space reflection) #20061
Conversation
Hello Mr.doob Yes, it is. I've already added the screenshot to the pr. I can run at 30fps at my win7 laptop with GTX 980M about 40% usage and 1920*1080 chrome maximized window. |
I found out that antialas was turned on and dpr was set before. |
On my iMac I get only about 10 FPS which is definitely to low. Apart from the performance aspect, the visual appearance of the pass still looks buggy. |
Yes, I just want to mention that the performance of this pass is not that bad on mac. I'll keep improving. |
Nice! It is looking much better indeed! |
Would it be hard to make this work with |
Thanks! Yes, it’s difficult for me to judge the ray position of the current pixel with PerspectiveCamera.
I'm still trying in this branch |
After just calc the distance from viewPosition to reflectRay using pointToLineDistance function, instead of calc the reflectRay position at this pixel, I think perspectiveCamera support is almost OK. But it need more adjustments ( some may be already done in OrthographicSSRPass ), I'll keep improving. |
After solving an obvious problem under the PerspectiveCamera, I think the SSRPass is ready to use. |
This one can be closed then? |
Yes, I'll merge these codes to SSRPass #20156. |
Demo Demo2
Inspired by Blender EEVEE SSR, and this tut ( mostly by the two screen grid images imgA imgB, I only read a little text and hardly read the code, then start writing my own code. )
Now just support OrthographicCamera. I'm trying to support PerspectiveCamera.
----------------EDIT 2----------------
Now support PerspectiveCamera. New PR: #20156
----------------EDIT----------------
Demo ScreenShot