Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen space reflections? #190

Closed
Ben-Mack opened this issue Apr 14, 2020 · 15 comments
Closed

Screen space reflections? #190

Ben-Mack opened this issue Apr 14, 2020 · 15 comments
Labels
feature request New feature request

Comments

@Ben-Mack
Copy link

Please consider implementing screen space reflections, it would be an amazing addition to improve Three.js realistic factor.

I've found some good sample, tutorial about SSR:
https://github.com/Domenicobrz/WebGL2-Screen-space-reflections
https://lettier.github.io/3d-game-shaders-for-beginners/screen-space-reflection.html

Related thread: mrdoob/three.js#8248

@vanruesc
Copy link
Member

Thanks for the references. I can't say that I'm a fan of SSR, but I'll consider adding it.

@vanruesc vanruesc added the feature request New feature request label Apr 14, 2020
@Mykita
Copy link

Mykita commented Apr 14, 2020

Just wanted to +1 the SSR request

@todaylg
Copy link

todaylg commented May 13, 2020

Just wanted to +1 the SSR request

@Ben-Mack
Copy link
Author

I've found an in-progress working implement for Three.js here: https://github.com/gkjohnson/threejs-sandbox/tree/master/screenSpaceReflectionsPass
The result is lacking blurring by roughness, but it does look very promising.
Maybe you could use it as a base to develop on?

@vanruesc
Copy link
Member

Thanks, that implementation does look pretty good 👌 My current plan is to finish the SSAOEffect, improve the ToneMappingEffect and then start working on SSR.

@gonnavis
Copy link

@vanruesc Looking forward to!

@jcguarinpenaranda
Copy link

+1 :D

@gonnavis
Copy link

gonnavis commented Aug 13, 2020

I wrote my own and make a pr to three.js, but now just support OrthographicCamera, I'm trying to support PerspectiveCamera.
Demo Demo2
clipboard

@gonnavis
Copy link

PerspectiveCamera support is OK now. mrdoob/three.js#20156

Demo

ffasdg

@veryprofessionaldodo
Copy link

Just here to add my +1. I'm currently experimenting with this framework for the company that I work with, and SSR would be quite beneficial!

@vinkovsky
Copy link

Hi! This will be super useful! is it currently under development?

@vanruesc
Copy link
Member

See this comment for the current plans regarding SSR.

I haven't forgotten about it, but it's currently not a great time to use SSR with three. The point of SSR is to render reflections without having to render the scene multiple times. This is currently not possible because three doesn't support MRT yet. Even if we were to implement SSR right now, we'd still have to render the scene many times to gather the various textures that are required to render the effect. You'd be better off using a CubeCamera or a Reflector.

@DolphinIQ
Copy link

@vanruesc Hi, youre doing awesome work in this repo! Just wanted to let you know MRT landed in three.js r129! Will this change priority of any features, like SSR?

@vanruesc
Copy link
Member

@DolphinIQ Hey, thanks! The priority of SSR doesn't really change, but MRT definitely opens up a path to an efficient implementation. We still need a reliable way to modify three's built-in materials, e.g. via NodeMaterials, to make effective use of this feature. Related comment: #292 (comment).

@vanruesc vanruesc mentioned this issue Feb 22, 2022
@vanruesc vanruesc mentioned this issue Feb 12, 2024
3 tasks
@vanruesc
Copy link
Member

Closing in favor of #571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

9 participants