Fix and document normal map handedness #18522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few examples use normal maps that have not been authored with the OpenGL normal map handedness convention. In these cases the normal scale y needs to be negated to get the normal maps to display correctly.
|
Thanks! |
|
Thanks for the very quick review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few examples use normal maps that have not been authored with the OpenGL normal map handedness convention. In these cases the normal scale y needs to be negated to get the normal maps to display correctly.
A mention of normal map handedness is also added to documentation - otherwise it can be hard to find out that the handedness differences exist and how to handle them in three.js.
Related earlier discussion in issue #11315