Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs/tests to reflect that sfixed is supported #166

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Update docs/tests to reflect that sfixed is supported #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/protobuf_ocaml_mapping.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ This page describes how the mapping between protobuf type system and OCaml is do
| sint64 | int64 | int | |
| fixed32 | int32 | int | |
| fixed64 | int64 | int | |
| sfixed32 | | | This encoding is not supported |
| sfixed64 | | | This encoding is not supported |
| sfixed32 | int32 | | |
| sfixed64 | int64 | | |
| bool | bool | | |
| string | string | | |
| bytes | bytes | | |
Expand Down
24 changes: 12 additions & 12 deletions src/tests/google_unittest/unittest.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ message TestAllTypes {
optional sint64 optional_sint64 = 6;
optional fixed32 optional_fixed32 = 7;
optional fixed64 optional_fixed64 = 8;
// SFIXED optional sfixed32 optional_sfixed32 = 9;
// SFIXED optional sfixed64 optional_sfixed64 = 10;
optional sfixed32 optional_sfixed32 = 9;
optional sfixed64 optional_sfixed64 = 10;
optional float optional_float = 11;
optional double optional_double = 12;
optional bool optional_bool = 13;
Expand Down Expand Up @@ -119,8 +119,8 @@ message TestAllTypes {
repeated sint64 repeated_sint64 = 36;
repeated fixed32 repeated_fixed32 = 37;
repeated fixed64 repeated_fixed64 = 38;
// SFIXED repeated sfixed32 repeated_sfixed32 = 39;
// SFIXED repeated sfixed64 repeated_sfixed64 = 40;
repeated sfixed32 repeated_sfixed32 = 39;
repeated sfixed64 repeated_sfixed64 = 40;
repeated float repeated_float = 41;
repeated double repeated_double = 42;
repeated bool repeated_bool = 43;
Expand Down Expand Up @@ -153,8 +153,8 @@ message TestAllTypes {
optional sint64 default_sint64 = 66 [default = 46 ];
optional fixed32 default_fixed32 = 67 [default = 47 ];
optional fixed64 default_fixed64 = 68 [default = 48 ];
// SFIXED optional sfixed32 default_sfixed32 = 69 [default = 49 ];
// SFIXED optional sfixed64 default_sfixed64 = 70 [default = -50 ];
optional sfixed32 default_sfixed32 = 69 [default = 49 ];
optional sfixed64 default_sfixed64 = 70 [default = -50 ];
optional float default_float = 71 [default = 51.5 ];
optional double default_double = 72 [default = 52e3 ];
optional bool default_bool = 73 [default = true ];
Expand Down Expand Up @@ -214,8 +214,8 @@ extend TestAllExtensions {
optional sint64 optional_sint64_extension = 6;
optional fixed32 optional_fixed32_extension = 7;
optional fixed64 optional_fixed64_extension = 8;
// SFIXED optional sfixed32 optional_sfixed32_extension = 9;
// SFIXED optional sfixed64 optional_sfixed64_extension = 10;
optional sfixed32 optional_sfixed32_extension = 9;
optional sfixed64 optional_sfixed64_extension = 10;
optional float optional_float_extension = 11;
optional double optional_double_extension = 12;
optional bool optional_bool_extension = 13;
Expand Down Expand Up @@ -254,8 +254,8 @@ extend TestAllExtensions {
repeated sint64 repeated_sint64_extension = 36;
repeated fixed32 repeated_fixed32_extension = 37;
repeated fixed64 repeated_fixed64_extension = 38;
// SFIXED repeated sfixed32 repeated_sfixed32_extension = 39;
// SFIXED repeated sfixed64 repeated_sfixed64_extension = 40;
repeated sfixed32 repeated_sfixed32_extension = 39;
repeated sfixed64 repeated_sfixed64_extension = 40;
repeated float repeated_float_extension = 41;
repeated double repeated_double_extension = 42;
repeated bool repeated_bool_extension = 43;
Expand Down Expand Up @@ -291,8 +291,8 @@ extend TestAllExtensions {
optional sint64 default_sint64_extension = 66 [default = 46 ];
optional fixed32 default_fixed32_extension = 67 [default = 47 ];
optional fixed64 default_fixed64_extension = 68 [default = 48 ];
// SFIXED optional sfixed32 default_sfixed32_extension = 69 [default = 49 ];
// SFIXED optional sfixed64 default_sfixed64_extension = 70 [default = -50 ];
optional sfixed32 default_sfixed32_extension = 69 [default = 49 ];
optional sfixed64 default_sfixed64_extension = 70 [default = -50 ];
optional float default_float_extension = 71 [default = 51.5 ];
optional double default_double_extension = 72 [default = 52e3 ];
optional bool default_bool_extension = 73 [default = true ];
Expand Down