Update docs/tests to reflect that sfixed is supported #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the google unittest is working or enabled. However there is already an integration test which does it. The best way for you to get familiar with testing would be to be able to run the integration like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First almost-useful pull request, just some house cleaning. After deeper investigation I discovered that
sfixed32andsfixed64seem to be supported just fine.I ran
make ; make testsand while a few near the end were strangely verbose (printing out records) they were all displayed in green. Assuming this means a successful run (I honestly have no idea), then this PR makes sense.If I didn't run the tests properly or in full, please let me know.