Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: install macOS app bundle #10879

Closed
Atemu opened this issue Nov 16, 2022 · 3 comments
Closed

meson: install macOS app bundle #10879

Atemu opened this issue Nov 16, 2022 · 3 comments

Comments

@Atemu
Copy link

Atemu commented Nov 16, 2022

Expected behavior of the wanted feature

Currently, there is the osxbundle.py tool which packagers must "manually" execute in their packaging scripts.

As a packager, I want generation and and installation of the mpv.app bundle on macOS/Darwin to be integrated into the build system so that I have a standardised, clean and less error-prone way to distribute them to users.

Alternative behavior of the wanted feature

The bundle could be a separate install target rather than being integrated into the regular install target.

@Akemi
Copy link
Member

Akemi commented Nov 16, 2022

i am not sure how our stance is atm, but we don't provide something like this for windows (completely self contained executable or installation process) and linux (Appimage etc) either. first and foremost mpv is a CLI player and is treated like this to this day.

the only benefit i see integrating the bundeling into the build system, is it being called via waf or meson itself. though it won't be "cleaner" or "less error-prone" than a separate called script.

like i mentioned in the closed issue, i believe the whole bundling script should be rewritten. atm it's very much some kind of frankenstein monster that grew over time. besides the swift parts, that were added a lot later, everything could probably be done in a lot nicer way.

@Akemi
Copy link
Member

Akemi commented Feb 22, 2024

just a heads up, i added a custom target in my PR #13529

Akemi added a commit to Akemi/mpv that referenced this issue Feb 22, 2024
@Akemi Akemi closed this as completed in 218d9e2 Feb 24, 2024
@Atemu
Copy link
Author

Atemu commented Feb 25, 2024

Thank you!

Leonardo-Boss pushed a commit to Leonardo-Boss/mpv that referenced this issue Feb 29, 2024
xrun1 pushed a commit to xrun1/mpv-svp-fix that referenced this issue Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants