Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle installation in osx/macOS #10878

Closed
Atemu opened this issue Nov 16, 2022 · 2 comments
Closed

Bundle installation in osx/macOS #10878

Atemu opened this issue Nov 16, 2022 · 2 comments

Comments

@Atemu
Copy link

Atemu commented Nov 16, 2022

Hi, we're upgrading our packaging to use mpv's meson build in Nixpkgs and something I've noticed is that mpv doesn't install a bundle by default.

We run TOOLS/osxbundle.py in our packaging script and then install the generated bundle "manually" to the output prefix. I'm wondering whether that's the intended way.

If it is, wouldn't it be better if the meson build built and installed the bundle automagically if darwin?

cc @Dudemanguy @Akemi

@Akemi
Copy link
Member

Akemi commented Nov 16, 2022

yes that's intended. the bundle creation is and was always something that wasn't part of the build process for various reasons. one of them is, that the script is kinda a clusterfuck and isn't really robust. it should be rewritten imo if it should be part of the build and installation process.

@Akemi Akemi closed this as completed Nov 16, 2022
@Atemu
Copy link
Author

Atemu commented Nov 16, 2022

Created #10879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants