chore: drop -g from npm install in ci config #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpl
approved these changes
Apr 16, 2024
Gudahtt
added a commit
to Gudahtt/webextension-polyfill
that referenced
this pull request
May 14, 2024
Changes made in mozilla#597 accidentally resulted in `webpack` and `webpack-cli` being added as dependencies in the manifest of the published package. This problem can be seen in v0.11.0. For more information, see mozilla#604. `webpack` and `webpack-cli` are used for bundler smoke tests that are run in CI. Rather than being installed during CI, these dependencies are now included in `devDependencies`. A new npm script has been added for running this script as well, to ensure that these dependencies are on the PATH when this script is run. The CircleCI config and the contributor docs have been updated to use the new npm script. You can test it by running `npm run test-module-bundlers-smoketest`. Fixes mozilla#604
Rob--W
pushed a commit
that referenced
this pull request
May 14, 2024
Changes made in #597 accidentally resulted in `webpack` and `webpack-cli` being added as dependencies in the manifest of the published package. This problem can be seen in v0.11.0. For more information, see #604. `webpack` and `webpack-cli` are used for bundler smoke tests that are run in CI. Rather than being installed during CI, these dependencies are now included in `devDependencies`. A new npm script has been added for running this script as well, to ensure that these dependencies are on the PATH when this script is run. The CircleCI config and the contributor docs have been updated to use the new npm script. You can test it by running `npm run test-module-bundlers-smoketest`. Fixes #604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After bumping the version directly on master, CI failed unexpectedly: af051ff
This is likely due to an image bump in 338d75f . Previously
npm i -ginstalled to~/.npm-global, possibly because the image was built after following the instructions from https://docs.npmjs.com/resolving-eacces-permissions-errors-when-installing-packages-globally#manually-change-npms-default-directory . The latest CI image does not have this override though, which causesnpm i -gto fail withEACCES: permission denied, mkdir '/usr/local/lib/node_modules/browserify'.