Skip to content

Commit

Permalink
chore: chromedriver and geckodriver dependencies along with circleci …
Browse files Browse the repository at this point in the history
…config (#584)

* chore(circleci): updated browser-tools orb to 1.4.8 and cimg/node to 20.12

* chore(deps-dev): bump chromedriver from 112.0.0 to 123.0.3

* chore(deps-dev): bump geckodriver from 3.2.0 to 4.3.3

* test: Update unit test to match new expected behaviors with changes applied from PR #582

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
rpl and dependabot[bot] authored Apr 11, 2024
1 parent 871b49d commit 338d75f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
9 changes: 4 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,13 @@
#
# - to try run jobs locally:
#
# circleci config process .circleci/config.yml > tmp/processed.yml
# circleci local execute -c tmp/processed.yml --job build-nodejs-current
# circleci local execute -c .circleci/config.yml build-nodejs-current
#
version: 2.1

orbs:
codecov: codecov/[email protected]
browser-tools: circleci/[email protected].1
browser-tools: circleci/[email protected].8

references:
working_directory: &working_directory ~/webextension-polyfill
Expand All @@ -26,14 +25,14 @@ references:
# See https://hub.docker.com/r/cimg/node/tags for the cimg/node tags
# related to specific nodejs versions.
docker:
- image: cimg/node:14.19
- image: cimg/node:20.12

defaults-browsers: &defaults-browsers
<<: *defaults
# Image variant (combined with circleci/browser-tools orb) used to
# run integration tests using Firefox, Chrome and Xvfb.
docker:
- image: cimg/node:14.19-browsers
- image: cimg/node:20.12-browsers


commands:
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
"babel-preset-minify": "0.5.2",
"browserify": "17.0.0",
"chai": "4.3.6",
"chromedriver": "112.0.0",
"chromedriver": "123.0.3",
"cross-env": "7.0.3",
"eslint": "8.35.0",
"finalhandler": "1.2.0",
"geckodriver": "3.2.0",
"geckodriver": "4.3.3",
"global-replaceify": "1.0.0",
"grunt": "1.6.1",
"grunt-babel": "8.0.0",
Expand Down
2 changes: 1 addition & 1 deletion test/test-browser-global.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe("browser-polyfill", () => {
runtime: {lastError: null},
};
const fakeBrowser = {
mycustomns: {mybrowserkey: true},
runtime: {id: "fakeid"},
};

return setupTestDOMWindow(fakeChrome, fakeBrowser).then(window => {
Expand Down

0 comments on commit 338d75f

Please sign in to comment.