Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject caching when multiple -arch arguments are present #898

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Reject caching when multiple -arch arguments are present #898

merged 2 commits into from
Dec 11, 2020

Commits on Dec 10, 2020

  1. Add test for -arch arguments 

    sccache currently barfs on multiple -arch. See mozilla#847.

This commit adds a test case showing that multiple -arch are currently
accepted.
    @indygreg
    indygreg committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    ce6b704 View commit details
    Browse the repository at this point in the history

  2. Don't cache if -arch specified multiple times (mozilla#847) 

    Attempting to use sccache with gcc/clang with -arch specified multiple
times (such as when compiling llvm's compiler-rt) results in a rather
cryptic error from the invoked clang command: `clang: error: cannot
use 'c++-cpp-output' output with multiple -arch options`.

While there are potentially other workarounds to this special case,
this commit takes the simplest approach and marks the invocation
as not cacheable if multiple -arch flags are present.

The test introduced by the previous commit demonstrates the desired
change in behavior.

Closes mozilla#847.
    @indygreg
    indygreg committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    943d62e View commit details
    Browse the repository at this point in the history