Reject caching when multiple -arch arguments are present #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sccache currently barfs on multiple -arch. See mozilla#847. This commit adds a test case showing that multiple -arch are currently accepted.
Attempting to use sccache with gcc/clang with -arch specified multiple times (such as when compiling llvm's compiler-rt) results in a rather cryptic error from the invoked clang command: `clang: error: cannot use 'c++-cpp-output' output with multiple -arch options`. While there are potentially other workarounds to this special case, this commit takes the simplest approach and marks the invocation as not cacheable if multiple -arch flags are present. The test introduced by the previous commit demonstrates the desired change in behavior. Closes mozilla#847.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the commit messages and #847 for more context for this change.
The argument parsing code performs multiple loops of the args and I'm unsure what the nuanced distinctions are between them. Because I don't fully grok what's going on here, I may have put the validation in the wrong loop. That's what code review is for!