#511 fixing InterfaceAdapter abstract name lookup. #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
commented
Dec 10, 2019
| @@ -692,7 +692,8 @@ else if (value instanceof Wrapper) { | |||
| reportConversionError(value, type); | |||
| } | |||
| else if (type.isInterface() && (value instanceof NativeObject | |||
| || value instanceof NativeFunction)) { | |||
| || value instanceof NativeFunction | |||
| || value instanceof ArrowFunction)) { | |||
There was a problem hiding this comment.
we should also allow to create adapters from arrowFunctions
|
Looks good. Thanks! |
This was referenced Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a follow up to #511 and #512
It fixes the lookup:
There are also tests now.