Issue #511, fixing InterfaceAdapter abstract name lookup. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now default methods are ignored, so they do not conflict with interface (abstract) methods to implement.
|
Would it be possible to add a test case so that this doesn't regress? For instance, it looks like we have some default method tests already in testsrc/jstests/java8/call-default-method.js |
|
Hi has there been anything blocking this fix from being merged in? I'm in a position at work where having this engine accept callback functions as |
|
Hi @Jeffrey-P-McAteer |
|
I ran into the same issue |
|
Suggest closing this as superseded by #631 |
|
Closing as superceded by #631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue #511. Now default methods are ignored, so they do not conflict with
interface (abstract) methods to implement.