Try setting superblock locals from an initialised exception handler

[carlosame]

The patch to ClassFileWriter contains two hunks: the first one is the real fix, the second unmaps dead exception handlers (that generally happen with nested finally clauses) which otherwise may trigger JRE verifier errors. That second hunk could be removed if the performance hit is considered undesirable.

Closes #915.

[tuchida]

Thank you very much for fixing it. Once this has been merged, #916 will be ready for review.

[tuchida]

Do you need to continue?
Since it is if (sbStart > eteStart && and if (eteStart > sbStart &&, the result is the same, but it feels more readable to write the same code as here.

rhino/src/org/mozilla/classfile/ClassFileWriter.java

Lines 1617 to 1620 in f33a0c1

	if (handlerSB.isInitialized()) {
	locals = handlerSB.getLocals();
	break;
	}

[carlosame]

Thank you for your review. I try to be efficient in a hot code path (the comment immediately above says so, and I agree), and while perhaps a smart JIT compiler would put a jump right there, I'd rather put it myself and make no assumptions about the JIT. :-)

[gbrail]

This is great -- thanks for tracking it down and fixing it!