Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try optional catch binding #916

Closed
wants to merge 4 commits into from
Closed

Try optional catch binding #916

wants to merge 4 commits into from

Conversation

tuchida
Copy link
Contributor

@tuchida tuchida commented May 29, 2021

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/try...catch#the_exception_identifier

  try {
    JSON.parse(text);
    return true;
  } catch {
    return false;
  }

The omission of the exception value is implemented, but there are another error. ref. #915
We need to either fix #915 or ignore VerifyError.

Closes #965

@tuchida tuchida marked this pull request as ready for review November 19, 2021 01:00
@tuchida
Copy link
Contributor Author

tuchida commented Jan 17, 2022

@gbrail @p-bakker Could you review it? Or should I wait for the problem to be fixed on Android?

@@ -49,17 +48,20 @@ public Name getVarName() {

/**
* Sets catch variable node, and sets its parent to this node.
*
* @param varName catch variable
* @throws IllegalArgumentException if varName is {@code null}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still holds true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1b473d6 I fixed.

@p-bakker
Copy link
Collaborator

Not sure if the Android thing should hold this PR (and others) back.

Left you one little comment, most of the changes are beyond me unfortunately

@tuchida
Copy link
Contributor Author

tuchida commented Jan 17, 2022

Thank you for your comment. I'll wait for a while.

@gbrail
Copy link
Collaborator

gbrail commented Jan 27, 2022

This works great. I'm going to squash some commits and push manually. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ES2019 Optional Catch binding java.lang.VerifyError in language/statements/try of test262
3 participants