-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try optional catch binding #916
Conversation
@@ -49,17 +48,20 @@ public Name getVarName() { | |||
|
|||
/** | |||
* Sets catch variable node, and sets its parent to this node. | |||
* | |||
* @param varName catch variable | |||
* @throws IllegalArgumentException if varName is {@code null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still holds true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1b473d6 I fixed.
Not sure if the Android thing should hold this PR (and others) back. Left you one little comment, most of the changes are beyond me unfortunately |
Thank you for your comment. I'll wait for a while. |
This works great. I'm going to squash some commits and push manually. Thanks! |
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/try...catch#the_exception_identifier
The omission of the exception value is implemented, but there are another error. ref. #915
We need to either fix #915 or ignore
VerifyError
.Closes #965