Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load fields that are needed from Google API for Big Query schema. #1013

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

jezdez
Copy link

@jezdez jezdez commented Sep 28, 2020

This fixes an issue with the Big Query query runner and us hitting the datasets API limit of 50 of the datasets API leading to an incomplete schema browser list.

Also in getredash#3673

Copy link

@emtwo emtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. You were able to confirm that this addressed the issue of datasets not being displayed?

@jezdez
Copy link
Author

jezdez commented Sep 30, 2020

@emtwo Yeah, I tried it locally and the tables missing in prod showed up for me.

@jezdez jezdez merged commit 3e76946 into master Sep 30, 2020
@jezdez jezdez deleted the bq-schema-slim branch September 30, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants