Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load fields that are needed from Google API for Big Query schema. #3673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Apr 3, 2019

What type of PR is this? (check all applicable)

  • Other

Description

While working with Big Query we noticed a pretty big amount of data being transferred from when fetching Big Query schema data. This change basically only loads the data that we really need for the schema.

Related Tickets & Documents

I used the Google API Explorer to build the values for the fields parameters: e.g. https://developers.google.com/apis-explorer/#p/bigquery/v2/bigquery.tables.get

More info for the fields parameter: https://developers.google.com/api-client-library/python/guide/performance#partial-response-fields-parameter

@arikfr
Copy link
Member

arikfr commented Jan 21, 2020

Hi,

(This is a template message, but I mean every word of it. Also you're welcome to reply)

Thank you for making this contribution. While we couldn't bring it to completion and merge, it's still very much appreciated. 🙇

In the past year the Redash code base gone under massive updates: on the backend we moved to Python 3 & RQ instead of Celery and on the frontend we replaced Angular with React. It's very likely this makes this PR irrelevant without significant changes. :-(

I'm closing this PR now. But if you're still interested in making it happen, let me know and I will reopen.

Thanks.

@arikfr arikfr closed this Jan 21, 2020
@arikfr arikfr deleted the bq-schema-slim branch January 21, 2020 09:12
@arikfr arikfr restored the bq-schema-slim branch January 21, 2020 09:12
@jezdez
Copy link
Member Author

jezdez commented Jan 22, 2020

@arikfr I think this would still be useful since it reduces the amount of data requested from BQ quite a bit.

@arikfr arikfr reopened this Jan 23, 2020
@arikfr
Copy link
Member

arikfr commented Jan 23, 2020

@jezdez 👍 I wonder how to reliably test this?

@jezdez
Copy link
Member Author

jezdez commented Sep 28, 2020

@arikfr No idea how to test this properly, no. I just updated the PR though since it fixes another issue with the BigQuery query runner of not using pagination for the dataset API.

@guidopetri
Copy link
Contributor

@jezdez , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@justinclift
Copy link
Member

@jezdez This does sound really useful. Hoping you're interested? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants