This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Show add club modal on page load if ?modal=add is in url on clubs page. #567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #566.
Note that it doesn't remove
?modal=add
when the modal is dismissed. This is partly because it's a hassle to implement and test, but also partly because I'd like to implement a more robust solution for giving every modal its own URL in v2, which I allude to a bit in #373 (comment) (this will make it a lot easier to allow older/non-JS browsers to use the modals too, among other things). As such, this PR is really just a quick fix to unblock mozilla/id.webmaker.org#51.