Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

Mailinglist signup doesn't redirect to our desired section/anchor #889

Closed
mmmavis opened this issue May 12, 2015 · 4 comments
Closed

Mailinglist signup doesn't redirect to our desired section/anchor #889

mmmavis opened this issue May 12, 2015 · 4 comments
Assignees
Labels

Comments

@mmmavis
Copy link
Member

mmmavis commented May 12, 2015

#654 has been merged and pushed staging. For testing purposes, I changed BSD config so that we are redirecting user to https://teach.mofostaging.net/events/?mailinglist=thanks#mailinglist for thank you message. However, BSD appends a bunch of query strings to the URL (e.g., https://teach.mofostaging.net/events/?mailinglist=thanks#mailinglist&action_code=FgxRWxYUOVIKQV0YAFIETFM&td=TVDLTsMwEPwVyycqNandpiQNF04gDhVIcECiyHKSbWPh2JEfFQ_x76zbqsXywTuzs7OeHwqDVJrWdJB75QP4wOcLzvltD1rbM6jMLjcQ6JQ66JSDNojokgwRsYuqOz1FI1EWTpUdg9gnzkStp9Tb6FpArpEeDnrEYnOGsRx7a-DcHyy6ia3S4Gn99o6I2pk4iq11gzh48rJEVetABhBd8p0zvszYMuNzwop6UdTF9aVDjUJ2ncO2kuXlKucVzyt24aMHJ-QOTJq0tt9Ka7mZLXNGrtayVSZY39-QBxNAEwTI4zN5JZzlqxvi9vWizNmE3EP7YTcz3IPh5eQO49raz80s0cmql2NAm7Q_n9JGR9xcKv-FhDLHbxXQlk2xaLMGmirjHIqs6lYyY_8Ojko5GDmk7NbyAxx5ki58kedDSuQKafICsu2JVwEmKBhsFzWcJMcw6e8f) and that breaks the "jump" - page doesn't scroll to the #mailinglist form where the thank you message is shown.

@mmmavis mmmavis added the bug label May 12, 2015
@mmmavis mmmavis added this to the Optimistic 80s Movie milestone May 12, 2015
@mmmavis
Copy link
Member Author

mmmavis commented May 12, 2015

can we fix this by something like

if (this.context.router.getCurrentQuery().mailinglist === "thanks") {
    window.location.hash = "mailinglist";
}

and remove hash from our redirect URL? 😬

@toolness
Copy link
Contributor

Hmm, that might work, though I'm not sure if it'd work on all browsers... Another option is to do something similar to #567 and actually show a modal!

@hannahkane
Copy link

Just a note that we should prioritize this. MP communications start next week, so we should have this in place by then.

@toolness
Copy link
Contributor

Ok. @sabrinang do you have any advice on the UX for this? I'm thinking that a modal would actually be more obvious/noticeable to users than the current design, which just puts the words "Thanks for signing up" in place of the form--we could hack-in ways to make the page scroll to that location on page load, such as mavis's suggestion above, but doing a modal would be more sure-fire from a technical standpoint since we already do it in other parts of the code. If it's a UX win too, then I recommend we just go with the modal, but otherwise we can try some hacks to ensure that the page scrolls to the right place when BSD brings them back to the site.

@mmmavis mmmavis self-assigned this May 13, 2015
mmmavis added a commit to mmmavis/learning.mozilla.org that referenced this issue May 14, 2015
toolness added a commit that referenced this issue May 14, 2015
Fixes #889 - show Thank You message on modal instead
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants