-
Notifications
You must be signed in to change notification settings - Fork 90
Implement design/copy changes on /Clubs #1142
Comments
@hannahkane @sabrinang mind giving me a ping when the design work has been finalized? Thanksssss 👍 🙈 |
This is ready to go. https://redpen.io/egd04381c2b4f26f22 @sabrinang - can you please add assets to this ticket? For now, the "If you'd like to get started on your own, check out these resources" sentence near the bottom should link to: http://mozilla.github.io/learning-networks/clubs/ |
@hannahkane @sabrinang don't forget to attach the mockup for the "see the full list" page as well 😉 (oh and the url for that page) |
Oh, these are the links for the "What does a Mozilla Club..." section:
|
@mmmavis @sabrinang - good call, Mavis, on the "See the full list" page. My suggestion for that would be:
|
I'm having hard time coming up with a url for that new page. |
what about just /clubs/list? |
redpen mockup of clubs list: https://redpen.io/qd0672bdaec511d12f |
+1 WFM |
+1 👍 |
@mmmavis - do you think this will land this heartbeat, or should we roll it into the next? |
Hey @hannahkane, I'm afraid not - this ticket actual needs a few days to build since it has lots of logic lying behind it. PR will be ready for review once I finish writing unit tests (will happen today). Then I'll pass it to @Pomax to review. 👍 |
That's fine. Will move to next heartbeat to finish! |
@sabrinang @hannahkane mind providing urls to the above links? |
projects we care about: don't know; I don't think that should be linked |
Code was merged into |
Design work is being finalized in #858
The text was updated successfully, but these errors were encountered: