Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

Implement design/copy changes on /Clubs #1142

Closed
hannahkane opened this issue Jul 30, 2015 · 17 comments
Closed

Implement design/copy changes on /Clubs #1142

hannahkane opened this issue Jul 30, 2015 · 17 comments
Assignees
Labels

Comments

@hannahkane
Copy link

Design work is being finalized in #858

@mmmavis
Copy link
Member

mmmavis commented Aug 2, 2015

@hannahkane @sabrinang mind giving me a ping when the design work has been finalized? Thanksssss 👍 🙈

@hannahkane
Copy link
Author

This is ready to go. https://redpen.io/egd04381c2b4f26f22

@sabrinang - can you please add assets to this ticket?

For now, the "If you'd like to get started on your own, check out these resources" sentence near the bottom should link to: http://mozilla.github.io/learning-networks/clubs/

@mmmavis
Copy link
Member

mmmavis commented Aug 24, 2015

@hannahkane @sabrinang don't forget to attach the mockup for the "see the full list" page as well 😉 (oh and the url for that page)

@hannahkane
Copy link
Author

@hannahkane
Copy link
Author

@mmmavis @sabrinang - good call, Mavis, on the "See the full list" page. My suggestion for that would be:

  • Same header as /Clubs, including the button
  • Replicate the "Where in the world..." section header from the /clubs page
  • Map
  • Full list (can use same styles as on the current /clubs page)
  • nothing below the list besides the site footer

@mmmavis
Copy link
Member

mmmavis commented Aug 24, 2015

I'm having hard time coming up with a url for that new page. https://teach.mozilla.org/clubs/full-list ?

@hannahkane
Copy link
Author

what about just /clubs/list?

@sabrinang
Copy link
Contributor

redpen mockup of clubs list: https://redpen.io/qd0672bdaec511d12f

@hannahkane
Copy link
Author

+1 WFM

@mmmavis
Copy link
Member

mmmavis commented Aug 25, 2015

what about just /clubs/list?

+1 👍

@mmmavis mmmavis mentioned this issue Aug 26, 2015
5 tasks
@hannahkane
Copy link
Author

@mmmavis - do you think this will land this heartbeat, or should we roll it into the next?

@mmmavis
Copy link
Member

mmmavis commented Aug 28, 2015

Hey @hannahkane,

I'm afraid not - this ticket actual needs a few days to build since it has lots of logic lying behind it. PR will be ready for review once I finish writing unit tests (will happen today). Then I'll pass it to @Pomax to review. 👍

@hannahkane
Copy link
Author

That's fine. Will move to next heartbeat to finish!

@mmmavis
Copy link
Member

mmmavis commented Aug 28, 2015

screen shot 2015-08-28 at 10 56 57 am

@sabrinang @hannahkane mind providing urls to the above links?

@hannahkane
Copy link
Author

projects we care about: don't know; I don't think that should be linked
Mozilla Club Captain: doesn't need to link
curriculum: /activities
Web Literacy: /teach-like-mozilla/web-literacy/

@hannahkane hannahkane added the P1 label Aug 31, 2015
@mmmavis
Copy link
Member

mmmavis commented Sep 3, 2015

Code was merged into develop as part of PR#1198

@mmmavis mmmavis closed this as completed Sep 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants