Ignore dynamically stored labels if Glean is not initialized #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
approved these changes
Oct 14, 2019
...re/android/src/test/java/mozilla/telemetry/glean/private/AccumulationsBeforeGleanInitTest.kt
Outdated
Show resolved
Hide resolved
We have 3 scenarios to consider: * Static labels. No database access needed. We just look at what is in memory. * Dynamic labels, initialized Glean. We look up in the database all previously stored labels in order to keep a maximum of allowed labels. * Dynamic labels, uninitialized Glean. We ignore potentially previously stored labels and just take what the user passed in. This potentially allows creating more than `MAX_LABELS` labels, but only before Glean is initialized.
badboy
force-pushed
the
pre_init_crash_labeled_kotlin
branch
from
29897d7 to
2ab9c47
Compare
Dexterp37
reviewed
Oct 14, 2019
...re/android/src/test/java/mozilla/telemetry/glean/private/AccumulationsBeforeGleanInitTest.kt
Show resolved
Hide resolved
mdboom
reviewed
Oct 14, 2019
| @@ -33,6 +34,8 @@ class AccumulationsBeforeGleanInitTest { | |||
| @Before | |||
| fun cleanup() { | |||
| Glean.testDestroyGleanHandle() | |||
| @Suppress("EXPERIMENTAL_API_USAGE") | |||
| Dispatchers.API.setTaskQueueing(true) | |||
There was a problem hiding this comment.
We may also want to clear the queue to be extra sure...
There was a problem hiding this comment.
Yes, but blindly clearing breaks other tests. We should take that in a follow-up, see the filed bug for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.