Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for accumulations happening before Glean inits #370

Closed

Conversation

Dexterp37
Copy link
Contributor

This is lacking the fix, but highlights the problem :)

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #370 into master will decrease coverage by 4.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #370      +/-   ##
============================================
- Coverage     75.21%   71.03%   -4.18%     
============================================
  Files            92       54      -38     
  Lines          5184     3739    -1445     
  Branches        633      469     -164     
============================================
- Hits           3899     2656    -1243     
+ Misses          824      706     -118     
+ Partials        461      377      -84
Impacted Files Coverage Δ Complexity Δ
glean-core/src/error_recording.rs 86.66% <0%> (-1.34%) 0% <0%> (ø)
glean-core/src/event_database/mod.rs 53.59% <0%> (-0.66%) 0% <0%> (ø)
glean-core/src/storage/mod.rs 94.59% <0%> (ø) 0% <0%> (ø) ⬇️
glean-core/src/lib.rs 61.9% <0%> (ø) 0% <0%> (ø) ⬇️
.../mozilla/telemetry/glean/private/UuidMetricType.kt
...ry/glean/acmigration/engines/UuidsStorageEngine.kt
...la/telemetry/glean/private/StringListMetricType.kt
...c/main/java/mozilla/telemetry/glean/Dispatchers.kt
...etry/glean/private/CustomDistributionMetricType.kt
...in/java/mozilla/telemetry/glean/utils/DateUtils.kt
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b988bb2...b730e54. Read the comment docs.

@Dexterp37 Dexterp37 force-pushed the pre_init_crash_labeled_kotlin branch from d0c1126 to 29bae63 Compare October 14, 2019 08:56
@Dexterp37
Copy link
Contributor Author

Closing in favour of #374

@Dexterp37 Dexterp37 closed this Oct 14, 2019
@Dexterp37 Dexterp37 deleted the pre_init_crash_labeled_kotlin branch October 14, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants