Remove nohost/StaticServer (dead code), always rewrite CSS files, fix remote script injection #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
everything seems to be working fine. I do see this showing up now though: |
|
@gideonthomas do you know what you were doing when that was caused, and/or what the project you're editing looks like (files/folders/types)? |
|
@humphd it's the default project and it seemed to happen when I switched files. So I'm guessing when the preview reloads? |
… remote script injection
|
@gideonthomas I can't reproduce that error. I think we should take this patch, and fix bugs we find as a result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm slowly working up the courage to tackle #549 and add Service Worker support. As I do, I'm re-familiarizing myself with our live dev server infrastructure. Today, I noticed a few bugs, and this fixes things:
nohost/StaticServermodule at all, so I've removed it. Kind of hilarious I wrote it at all, since it's 100% dead code :)PostMessageTransportvs. the hack we had in theHTMLServerbefore. I think this might actually fix a few other scroll-position bugs that @flukeout mentioned in Thimble, specifically https://github.com/mozilla/thimble.mozilla.org/issues/1671server.urlToPath()method to ignore non-Blob/relative path URLs. This was causing an exception when HTML docs included links to stylesheets on the web (i.e., we were looking for a related doc in the editor, but we don't have one because it's actually anhttp://url).background-image: url(something.png);and when you first load it, the image won't show. You have to edit the CSS file to make it actually rewrite it, and purge the existing, incorrect cached URL from the Blob Cache.